[webkit-reviews] review granted: [Bug 91070] Add window resize benchmark : [Attachment 152906] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 91070: Add window resize benchmark
https://bugs.webkit.org/show_bug.cgi?id=91070

Attachment 152906: Patch
https://bugs.webkit.org/attachment.cgi?id=152906&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152906&action=review


> PerformanceTests/Interactive/window-resize.html:4
> +window.location =
"../Parser/resources/html5.html?interactiveTest=exerciseWindowResize";

Please make sure this technique works on Qt, Chromium, & Mac.

> PerformanceTests/Parser/resources/html5.html:557
> +  <script><!--

Do we really need <!-- ~ -->?

> PerformanceTests/Parser/resources/html5.html:558
> +  if (0 <= window.location.search.indexOf("interactiveTest")) {

Maybe we can make it more genetic by specifying the path instead?
e.g. html5.html?inject=Interactive/resources/driver.js
and you do:
document.write("<script src='../../" + injectedScript + "'></script>");