[webkit-reviews] review requested: [Bug 91572] Test cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case : [Attachment 152913] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 20:58:44 PDT 2012


yosin at chromium.org has asked  for review:
Bug 91572: Test cases in DecimalTest should use EXPECT_STREQ for ease of
debugging test case
https://bugs.webkit.org/show_bug.cgi?id=91572

Attachment 152913: Patch 2
https://bugs.webkit.org/attachment.cgi?id=152913&action=review

------- Additional Comments from yosin at chromium.org
Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Change summary to extend scope of using EXPECT_STREQ for all test cases which
use EXPECT_EQ with String class.
* Introduce EXPECT_DECIMAL_STREQ
* Change DecimalTest::stepDown() and stepUp() for adopting
EXPECT_DECIMAL_STREQ.


More information about the webkit-reviews mailing list