[webkit-reviews] review denied: [Bug 91572] DecimalTest toString test cases should use EXPECT_STREQ for ease of debugging test case : [Attachment 152911] Patch 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 17 20:36:31 PDT 2012
Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 91572: DecimalTest toString test cases should use EXPECT_STREQ for ease of
debugging test case
https://bugs.webkit.org/show_bug.cgi?id=91572
Attachment 152911: Patch 1
https://bugs.webkit.org/attachment.cgi?id=152911&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152911&action=review
> Source/WebKit/chromium/tests/DecimalTest.cpp:1025
> + EXPECT_STREQ("0", Decimal::zero(Positive).toString().ascii().data());
Please add another macro like EXPECT_DECIMALSTRING(expectation, decimal)
EXPECT_STREQ(expectation, decimal.toString().ascii().data())
More information about the webkit-reviews
mailing list