[webkit-reviews] review denied: [Bug 90778] [EFL][WK2] Zoom the page when the mouse wheel event occurs with pressed control key. : [Attachment 152679] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 90778: [EFL][WK2] Zoom the page when the mouse wheel event occurs with
pressed control key.
https://bugs.webkit.org/show_bug.cgi?id=90778

Attachment 152679: Patch
https://bugs.webkit.org/attachment.cgi?id=152679&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152679&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:160
> +    if (priv->isWheelZoomEnabled &&
evas_key_modifier_is_set(wheelEvent->modifiers, "Control") &&
!wheelEvent->direction) {
> +	   double currentPageZoomFactor =
priv->pageClient->page()->pageZoomFactor();
> +	   if (wheelEvent->z < 0 && currentPageZoomFactor < zoomMaximum)
> +	      
priv->pageClient->page()->setPageZoomFactor(currentPageZoomFactor *
zoomInRatio);
> +	   if (wheelEvent->z > 0 && currentPageZoomFactor > zoomMinimum)
> +	      
priv->pageClient->page()->setPageZoomFactor(currentPageZoomFactor *
zoomOutRatio);
> +	   return true;
> +    }
> +

You are not even checking whether the web process is using the wheel events, so
this can break pages :-(

If you once do a webkit efl summit in korea you should invite me :-) Then I can
explain must of this stuff at once.