[webkit-reviews] review denied: [Bug 90603] [EFL] Support the permission function of the Web Notification. : [Attachment 152903] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 20:03:48 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 90603: [EFL] Support the permission function of the Web Notification.
https://bugs.webkit.org/show_bug.cgi?id=90603

Attachment 152903: Patch
https://bugs.webkit.org/attachment.cgi?id=152903&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152903&action=review


> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:80
> +    PermissionsMap::iterator iter =
m_cachedPermissions.find(context->securityOrigin()->toString());
> +
> +    if (iter == m_cachedPermissions.end())
> +	   return PermissionNotAllowed;
> +
> +    if (iter->second)
> +	   return PermissionAllowed;
> +
>      return PermissionDenied;
>  }

So this will never reach the last return? What is the difference between Denied
and NotAllowed?

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:82
> +void NotificationPresenterClientEfl::addPermissionCache(const char* domain,
const bool isAllowed)

addTo ?

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:89
> +    PermissionsMap::iterator iter =
m_cachedPermissions.find(String(domain));
> +
> +    if (iter == m_cachedPermissions.end())
> +	   return;
> +
> +    m_cachedPermissions.add(String(domain), isAllowed);

So you check whehter is is already cached. If it is not you return, thus never
cache :-(


More information about the webkit-reviews mailing list