[webkit-reviews] review denied: [Bug 88943] Null-pointer crash when a list marker is attached to a ruby with display:block : [Attachment 147214] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has denied dstockwell at chromium.org's
request for review:
Bug 88943: Null-pointer crash when a list marker is attached to a ruby with
display:block
https://bugs.webkit.org/show_bug.cgi?id=88943

Attachment 147214: Patch
https://bugs.webkit.org/attachment.cgi?id=147214&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147214&action=review


cced Roland (ruby code expert) so that he could comment.

> LayoutTests/fast/ruby/ruby-block-outside-marker-expected.txt:8
> +	     RenderListMarker at (-17,10) size 7x18: bullet

This tree does not look right. Why did RenderListMarker go inside the
RenderRuby.  This will cause problems down the road. It should be the immediate
child of RenderListItem or be in an anonymous block just under RenderListItem.
The bug is probably in RenderBlock::addChildIgnoringAnonymousColumnBlocks it
didnt do the beforeChild calculation properly to put RenderListMarker before
the RenderRuby.