[webkit-reviews] review granted: [Bug 91533] [Chromium-Android] Run ref tests together to avoid expensive driver restarts : [Attachment 152883] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 91533: [Chromium-Android] Run ref tests together to avoid expensive driver
restarts
https://bugs.webkit.org/show_bug.cgi?id=91533

Attachment 152883: Patch
https://bugs.webkit.org/attachment.cgi?id=152883&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152883&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:62
> +    def __init__(self, ref_tests, **kwargs):

oh, I meant add an integration test in run_webkit_tests_integrationtest.py that
tested that --shard-ref-tests actually ran properly (I don't care as much that
the tests are actually sharded in that case, just that we don't error out).

This is fine, too, though.