[webkit-reviews] review granted: [Bug 91472] [chromium] Remove awkward anchorPoint usage that implicitly affects layer position : [Attachment 152796] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 17 16:37:14 PDT 2012
Adrienne Walker <enne at google.com> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 91472: [chromium] Remove awkward anchorPoint usage that implicitly affects
layer position
https://bugs.webkit.org/show_bug.cgi?id=91472
Attachment 152796: Patch
https://bugs.webkit.org/attachment.cgi?id=152796&action=review
------- Additional Comments from Adrienne Walker <enne at google.com>
R=me. This really cleans things up a lot! I feel pretty comfortable with this
given the amount of layout tests that would break if the transform math were
wrong.
However, CCDamageTrackerTest suffers a lot from
http://www.webkit.org/coding/coding-style.html#float-suffixes. Your patch adds
a few more, but there's enough in the file that I don't know that it's worth
calling out specifically.
More information about the webkit-reviews
mailing list