[webkit-reviews] review granted: [Bug 91456] IndexedDB: Key generator state not maintained across connections : [Attachment 152854] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 91456: IndexedDB: Key generator state not maintained across connections
https://bugs.webkit.org/show_bug.cgi?id=91456

Attachment 152854: Patch
https://bugs.webkit.org/attachment.cgi?id=152854&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152854&action=review


> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:50
> +const int64_t kKeyGeneratorInitialNumber = 1; // From the IndexedDB
specification.

Nit: Normally we don't prefix constants or enum values with k. 
KeyGeneratorInitialNumber is fine.  Hmm, I see you use k for constants in other
places.  Maybe a follow up patch to remove all the k prefixes in IDB code?

> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:680
> +	       const char *p = it->key().begin();
> +	       const char *limit = it->key().end();

Nit: * next to char.  E.g., const char* p =