[webkit-reviews] review granted: [Bug 91525] REGRESSION(r122215) - RenderObject::willRenderImage crashes on null view() : [Attachment 152841] Reword comment

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 91525: REGRESSION(r122215) - RenderObject::willRenderImage crashes on null
view()
https://bugs.webkit.org/show_bug.cgi?id=91525

Attachment 152841: Reword comment
https://bugs.webkit.org/attachment.cgi?id=152841&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152841&action=review


> Source/WebCore/ChangeLog:10
> +

It would be nice to mention why you couldn't produce a test case in your
ChangeLog.

> Source/WebCore/rendering/RenderObject.cpp:2696
> +    // If the document is being destroyed or has not been attached, then
this
> +    // RenderObject will not be rendered.

I am fine with the comment as-is though Eric may want to comment further.