[webkit-reviews] review granted: [Bug 91408] IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h : [Attachment 152609] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 15:06:18 PDT 2012


Adam Barth <abarth at webkit.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 91408: IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h
https://bugs.webkit.org/show_bug.cgi?id=91408

Attachment 152609: Patch
https://bugs.webkit.org/attachment.cgi?id=152609&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152609&action=review


> Source/WebKit/chromium/public/WebIDBMetadata.h:49
>      WebString version;
> +    int64_t intVersion;

Is the plan to delete version and rename intVersion to version at some point? 
I wonder if it make sense to add a macro for selecting between the two?  Maybe
add a FIXME explaining your future plans?


More information about the webkit-reviews mailing list