[webkit-reviews] review granted: [Bug 86022] Refactor layer-related logic out of RenderBoxModelObject : [Attachment 152439] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 14:41:21 PDT 2012


Julien Chaffraix <jchaffraix at webkit.org> has granted Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 86022: Refactor layer-related logic out of RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=86022

Attachment 152439: Patch
https://bugs.webkit.org/attachment.cgi?id=152439&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152439&action=review


> Source/WebCore/ChangeLog:11
> +	   of adding non-RenderBoxModelObject layer supprt.

typo: support

> Source/WebCore/rendering/RenderBoxModelObject.cpp:345
> +    RenderTransformableObject::styleDidChange(diff, oldStyle);

This changes a bit the order in which we do the previous operations but I think
it's safe.

> Source/WebCore/rendering/RenderLayer.cpp:1095
> +	   RenderObject* renderer = curr->renderer();

RenderTransformableObject no?


More information about the webkit-reviews mailing list