[webkit-reviews] review granted: [Bug 91316] Remove ENTITY_REFERENCE_NODE from WebCore : [Attachment 152802] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai (vacation through 7/31) <ojan at chromium.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 91316: Remove ENTITY_REFERENCE_NODE from WebCore
https://bugs.webkit.org/show_bug.cgi?id=91316

Attachment 152802: Patch
https://bugs.webkit.org/attachment.cgi?id=152802&action=review

------- Additional Comments from Ojan Vafai (vacation through 7/31)
<ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152802&action=review


r=me assuming you make the test changes and all the EWS bots go green. Thanks
for doing this!

> Source/WebKit/chromium/public/WebNode.h:77
> +	   // EntityReferenceNodes are deprecated and impossible possible to
create in WebKit.

s/possible //

> LayoutTests/fast/dom/Window/get-set-properties-expected.txt:38
> +*** FAIL: canGet('EntityReference') should be 'true' but instead is false.
***

Can you just delete this line from the test?

> LayoutTests/fast/dom/dom-constructors-expected.txt:15
> +FAIL TryAllocate('EntityReference') should be exception. Was no constructor.


ditto

> LayoutTests/fast/dom/wrapper-classes-expected.txt:52
> +FAIL jsWrapperClass(xmlDocument.createEntityReference()) should be
EntityReference. Threw exception TypeError: 'undefined' is not a function
(evaluating 'xmlDocument.createEntityReference()')
> +FAIL jsWrapperClass(xmlDocument.createEntityReference().__proto__) should be
EntityReferencePrototype. Threw exception TypeError: 'undefined' is not a
function (evaluating 'xmlDocument.createEntityReference()')
> +FAIL jsWrapperClass(xmlDocument.createEntityReference().constructor) should
be EntityReferenceConstructor. Threw exception TypeError: 'undefined' is not a
function (evaluating 'xmlDocument.createEntityReference()')

ditto