[webkit-reviews] review denied: [Bug 91531] Web Inspector: intern strings when processing timeline records : [Attachment 152803] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 91531: Web Inspector: intern strings when processing timeline records
https://bugs.webkit.org/show_bug.cgi?id=91531

Attachment 152803: Patch
https://bugs.webkit.org/attachment.cgi?id=152803&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152803&action=review


> Source/WebCore/inspector/front-end/utilities.js:729
> +    deepIntern: function(obj)

internObject?

> Source/WebCore/inspector/front-end/utilities.js:737
> +		   this.deepIntern(obj[field]);

Do you want to introduce a re-entrance guard here to say support up to 100
levels? Stack overflow is sometimes hard to debug.