[webkit-reviews] review granted: [Bug 89900] Unneeded tree walking when adding or removing children due to RenderCounter / RenderQuote logic : [Attachment 152798] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Elliott Sprehn
<esprehn at gmail.com>'s request for review:
Bug 89900: Unneeded tree walking when adding or removing children due to
RenderCounter / RenderQuote logic
https://bugs.webkit.org/show_bug.cgi?id=89900

Attachment 152798: Patch
https://bugs.webkit.org/attachment.cgi?id=152798&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152798&action=review


> Source/WebCore/ChangeLog:3
> +	   Unneeded tree walking when adding or removing children due to
RenderCounter / RenderQuote logic

Please fix the title. Like Regression(xyz): Crash in ...

> Source/WebCore/ChangeLog:8
> +	   Check for document destruction during insertion to avoid crashes and
also since it's just unneeded

Please example the why part, like it causes null ptr crash since the view is
null.