[webkit-reviews] review denied: [Bug 91529] Make Animation, TimingFunction and TransformOperation thread safe : [Attachment 152794] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 12:00:30 PDT 2012


David Levin <levin at chromium.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 91529: Make Animation, TimingFunction and TransformOperation thread safe
https://bugs.webkit.org/show_bug.cgi?id=91529

Attachment 152794: Patch
https://bugs.webkit.org/attachment.cgi?id=152794&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This doesn't have much context. It would be nice to have a over arching bug
with more context on what is being done.

Anyway, I'm dubious of this patch since a cursory glance revealed something
that seems fundamentally incorrect in it.
 
I'm hesitant to point it out because it makes me feel like the implications of
this change haven't been examined. Please look carefully at these classes and
make sure it is safe to do this. (Hint: It isn't right now.)


More information about the webkit-reviews mailing list