[webkit-reviews] review denied: [Bug 90880] Web Inspector: adding pause icon for JavaScript debugging : [Attachment 152787] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 11:16:51 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 90880: Web Inspector: adding pause icon for JavaScript debugging
https://bugs.webkit.org/show_bug.cgi?id=90880

Attachment 152787: Patch
https://bugs.webkit.org/attachment.cgi?id=152787&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152787&action=review


> Source/WebCore/inspector/DOMNodeHighlighter.cpp:73
> +static Color parseColor(const RefPtr<InspectorObject>* colorObject)

Overlay is a utility class, it should not depend on the inspector transport
objects.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:585
> +    m_highlightData = adoptPtr(new HighlightData());

I think this method should receive PassRefPtr<HighlightData> instead.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:594
> +    m_highlightData = adoptPtr(new HighlightData());

ditto

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:611
> +    highlightConfig->getBoolean("showInfo", &showInfo);

ditto


More information about the webkit-reviews mailing list