[webkit-reviews] review denied: [Bug 91502] Avoid repainting in RenderLayer::scrollTo where possible. : [Attachment 152764] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied vollick at chromium.org's
request for review:
Bug 91502: Avoid repainting in RenderLayer::scrollTo where possible.
https://bugs.webkit.org/show_bug.cgi?id=91502

Attachment 152764: Patch
https://bugs.webkit.org/attachment.cgi?id=152764&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152764&action=review


> Source/WebCore/rendering/RenderLayer.cpp:1669
> +    const bool movedNonCompositedLayer = updateLayerPositionsAfterScroll();

const bool makes no sense as a return value.

> Source/WebCore/rendering/RenderLayer.cpp:1701
> +    for (RenderObject* child = renderer()->firstChild(); child; child =
child->nextSibling())
> +	   hasNonLayerChildObject |= !child->hasLayer();

I don't understand why you're checking for non-layer children.

> Source/WebCore/rendering/RenderLayer.cpp:1705
> +    const bool needsFullRepaint = movedNonCompositedLayer ||
hasNonLayerChildObject;

We don't tent to use const for local variables.