[webkit-reviews] review granted: [Bug 86215] [chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class : [Attachment 152714] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 11:00:44 PDT 2012


Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 86215: [chromium] MediaStream API: Moving the mock create* WebRTC calls
into a shadow Platform class
https://bugs.webkit.org/show_bug.cgi?id=86215

Attachment 152714: Patch
https://bugs.webkit.org/attachment.cgi?id=152714&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152714&action=review


> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h:40
> +    virtual void cryptographicallyRandomValues(unsigned char* buffer, size_t
length) OVERRIDE;

Are we sure we want to override this function?


More information about the webkit-reviews mailing list