[webkit-reviews] review granted: [Bug 89624] Add parsing and style application for css3-images image-orientation : [Attachment 152705] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted David Barr
<davidbarr at chromium.org>'s request for review:
Bug 89624: Add parsing and style application for css3-images image-orientation
https://bugs.webkit.org/show_bug.cgi?id=89624

Attachment 152705: Patch
https://bugs.webkit.org/attachment.cgi?id=152705&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152705&action=review


> Source/WebCore/css/CSSPrimitiveValueMappings.h:4134
> +    default:
> +	   ASSERT_NOT_REACHED();

Nit: Since there are only 9 values, I would just list the other 5 here and omit
the default: case.  This will allow the compiler to give a warning if someone
adds a value to ImageOrientationEnum and doesn't know to update this switch.

> Source/WebCore/rendering/style/RenderStyle.h:1670
> +    static ImageOrientationEnum initialImageOrientation() { return
DefaultImageOrientation; }

I would probably use OriginTopLeft explicitly since this doesn't depend on the
exif spec.

> Source/WebCore/rendering/style/StyleRareInheritedData.h:99
> +    unsigned m_imageOrientation : 3; // ImageOrientationEnum - 1

Why ImageOrientationEnum - 1 ? To save a bit? I would just use the extra bit to
avoid the possible human error.