[webkit-reviews] review denied: [Bug 90880] Web Inspector: adding pause icon for JavaScript debugging : [Attachment 152744] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 90880: Web Inspector: adding pause icon for JavaScript debugging
https://bugs.webkit.org/show_bug.cgi?id=90880

Attachment 152744: Patch
https://bugs.webkit.org/attachment.cgi?id=152744&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152744&action=review


> Source/WebCore/inspector/DOMNodeHighlighter.cpp:492
> +    , m_isPausedInDebugger(false)

Nit: we rarely use "is" prefix.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:501
> +	   drawHighlight(context);

Nit: You could simply call drawHighlight here and bail out from there in case
of no highlightData.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:541
> +void InspectorOverlay::setIsPausedInDebugger(bool flag)

setPausedInDebugger, sorry about that.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1038
> +    m_overlay->setHighlight(m_document.get(), m_highlightData.get());

m_document will expire upon reset.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1606
> +    m_overlay->getHighlight(m_highlightData->node ?
m_highlightData->node->document() : m_document.get(), m_highlightData.get(),
highlight);

I was hoping m_highlightData could go away from the DOMAgent.