[webkit-reviews] review denied: [Bug 91481] Decimal::toString should not round integer value. : [Attachment 152724] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 91481: Decimal::toString should not round integer value.
https://bugs.webkit.org/show_bug.cgi?id=91481

Attachment 152724: Patch 1
https://bugs.webkit.org/attachment.cgi?id=152724&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152724&action=review


> Source/WebCore/ChangeLog:14
> +	   (WebCore::Decimal::toString): When the value is an integer, we don't

> +	   round coefficient to DBL_DIG(15) digits.

Why do we need the rounding for non-integer cases?

> Source/WebKit/chromium/tests/DecimalTest.cpp:1045
> +    // 8639999913600001=Date.UTC(275760, 8, 12, 0, 0, 0 1)

Understing it helps nothing.  Please remove the comment.

> Source/WebKit/chromium/tests/DecimalTest.cpp:1046
> +    EXPECT_STREQ(("8639999913600001"), encode(8639999913600001, 0,
Positive).toString().ascii().data());

We need more test cases.  For example, MaxCoefficient with various exponents.