[webkit-reviews] review granted: [Bug 90716] Move zero-length-subpaths from RenderSVGShape to RenderSVGPath : [Attachment 152046] Update per reviewer comments

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Philip Rogers
<pdr at google.com>'s request for review:
Bug 90716: Move zero-length-subpaths from RenderSVGShape to RenderSVGPath
https://bugs.webkit.org/show_bug.cgi?id=90716

Attachment 152046: Update per reviewer comments
https://bugs.webkit.org/attachment.cgi?id=152046&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152046&action=review


Looks great, r=me with a minor comment.

> Source/WebCore/rendering/svg/RenderSVGPath.cpp:56
> +FloatRect RenderSVGPath::updateStrokeBoundingBox() const

I think updateStrokeBoundingBox is a misleading name, as it returns a new
strokeBoundingBox, instead of updating the m_strokeBoundingBox.
Maybe you can come up with a better name not involving update...

> Source/WebCore/rendering/svg/RenderSVGPath.cpp:96
> +    context->save();

Use GraphicsContextStateSaver stateSaver(*context, true) here.