[webkit-reviews] review denied: [Bug 91196] Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel. : [Attachment 152699] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 16 23:24:14 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Vivek Galatage
<vivekgalatage at gmail.com>'s request for review:
Bug 91196: Web Inspector: refactor InspectorController::connectFrontend() to
accept InspectorFrontendChannel.
https://bugs.webkit.org/show_bug.cgi?id=91196

Attachment 152699: Patch
https://bugs.webkit.org/attachment.cgi?id=152699&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152699&action=review


I only have two small comments, otherwise it looks good!

> Source/WebCore/inspector/InspectorController.cpp:216
> +    m_inspectorFrontendChannel = frontendChannel;

You no longer need to store it locally, just create the front-end off the
channel that is passed!

> Source/WebKit2/WebProcess/WebPage/WebPage.h:193
> +    WebInspectorClient* inspectorClient() const { return m_inspectorClient;
};

Instead of exposing it, I would make WebInspector constructor receive the
InspectorFrontendChannel* in the constructor to minimize the API surface.

> Source/WebKit/blackberry/Api/WebPage.cpp:493
> +    m_inspectorClient = new WebCore::InspectorClientBlackBerry(this);

It is using namespace WebCore at the top, no need for WebCore.

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:392
> +    inspectorController()->connectFrontend(this);

FYI: You should have passed InspectorClientImpl instance here, but I actually
think this should work since the agent has greater lifespan.


More information about the webkit-reviews mailing list