[webkit-reviews] review granted: [Bug 90532] Shadow DOM for img element : [Attachment 152666] Patch (Changed ChangeLog)

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 90532: Shadow DOM for img element
https://bugs.webkit.org/show_bug.cgi?id=90532

Attachment 152666: Patch (Changed ChangeLog)
https://bugs.webkit.org/attachment.cgi?id=152666&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152666&action=review


Overall looks good. Added some nits.

> Source/WebCore/html/HTMLImageElement.h:142
> +    if (!node)

Nit: this looks strange. You can do this check in toHTMLImageElement()

> Source/WebCore/loader/ImageLoaderClient.h:35
> +#include "Element.h"

Do we need this? A forward declaration looks sufficient.

> Source/WebCore/loader/ImageLoaderClient.h:47
> +    virtual void derefElement() = 0;

Which element is going to be ref/deref-ed? The name could imply that.

> Source/WebCore/rendering/RenderImage.cpp:571
> +    if (node()->hasTagName(imgTag))

Could use isHTMLImageElement()