[webkit-reviews] review granted: [Bug 91439] nrwt: move a bunch of printing code from manager.py to printing.py : [Attachment 152635] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 91439: nrwt: move a bunch of printing code from manager.py to printing.py
https://bugs.webkit.org/show_bug.cgi?id=91439

Attachment 152635: Patch
https://bugs.webkit.org/attachment.cgi?id=152635&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152635&action=review


> Tools/ChangeLog:10
> +	   live in printing.py; this patch moves a large chunk of hit that
> +	   prints all of the stuff after the run completes.

This sentence is missing some words. Not sure what it's supposed to say. :)

> Tools/Scripts/webkitpy/layout_tests/views/printing.py:207
> +				  directory_test_timings,
individual_test_timings,
> +				  result_summary):

This indentation is funny

> Tools/Scripts/webkitpy/layout_tests/views/printing.py:245
> +				     result_summary):

ditto