[webkit-reviews] review denied: [Bug 90222] [chromium, android] Reloading a page with a different user agent can cause the page to be zoomed in : [Attachment 150693] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied
dfalcantara at chromium.org's request for review:
Bug 90222: [chromium, android] Reloading a page with a different user agent can
cause the page to be zoomed in
https://bugs.webkit.org/show_bug.cgi?id=90222

Attachment 150693: Patch
https://bugs.webkit.org/attachment.cgi?id=150693&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150693&action=review


> Source/WebKit/chromium/public/WebFrame.h:324
> +    virtual void reloadWithOverrideURL(const WebURL& overrideUrl, bool
ignoreCache = false, bool resetState = false) = 0;

there are too many boolean parameters.	think how confusing the callsite will
look when there is a string of bools?

since resetState is implemented by calling setResetPageStateOnLoad, it seems
like you could just expose
that method on WebView / WebFrame.  or, perhaps there is a WebViewClient /
WebFrameClient method that
you could hook to then call to change the page scale factor at the right time?

> Source/WebKit/chromium/src/WebViewImpl.cpp:3223
> +	   currentItem->clearScrollPoint();

why do you want to clear the scroll position?  normally, reloading a page
preserves
the scroll position.