[webkit-reviews] review granted: [Bug 91350] [chromium] Unify compositor quad transforms into content space : [Attachment 152593] Handle empty bounds in create quad state

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 16 15:56:06 PDT 2012


Kenneth Russell <kbr at google.com> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 91350: [chromium] Unify compositor quad transforms into content space
https://bugs.webkit.org/show_bug.cgi?id=91350

Attachment 152593: Handle empty bounds in create quad state
https://bugs.webkit.org/attachment.cgi?id=152593&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152593&action=review


Mostly a rubber stamp, though I did look through the code. One question. Go
ahead and cq+ if this isn't an issue.

> Source/WebKit/chromium/tests/CCQuadCullerTest.cpp:202
> +    ASSERT_EQ(quadList.size(), 12u);

Will this get run in non-debug builds?


More information about the webkit-reviews mailing list