[webkit-reviews] review granted: [Bug 90923] IndexedDB: Introduce putWithIndexKeys and calculate them in the renderer : [Attachment 152020] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 90923: IndexedDB: Introduce putWithIndexKeys and calculate them in the
renderer
https://bugs.webkit.org/show_bug.cgi?id=90923

Attachment 152020: Patch
https://bugs.webkit.org/attachment.cgi?id=152020&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152020&action=review


> Source/WebKit/chromium/public/WebIDBObjectStore.h:57
> +    virtual void putWithIndexKeys(const WebSerializedScriptValue&, const
WebIDBKey&, PutMode, WebIDBCallbacks*, const WebIDBTransaction&, const
WebVector<WebString>&, const WebVector<WebIndexKeys>&, WebExceptionCode&) {
WEBKIT_ASSERT_NOT_REACHED(); }

nit: give the WebVector<WebString> parameter a name?  using indexNames would
help a lot.