[webkit-reviews] review denied: [Bug 91354] Machine stack marker should not gather values already piled up on the stack before JSC working : [Attachment 152470] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied hojong.han at samsung.com's
request for review:
Bug 91354: Machine stack marker should not gather values already piled up on
the stack before JSC working
https://bugs.webkit.org/show_bug.cgi?id=91354

Attachment 152470: Patch
https://bugs.webkit.org/attachment.cgi?id=152470&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I don't think this change is valid.  The StackBounds will be captured on the
first call into WebCore, when the thread data is initialized.  This may occur
at a deep stack depth.	Subsequent calls into WebCore may occur at a much
shallower stack depth.	It certainly is the case that there may be some range
of the stack that we currently mark, which one could safely avoid marking – but
I don't think this patch safely determines what that line is (also, I'm not
sure how one would safely define this high water mark).