[webkit-reviews] review denied: [Bug 91301] create different WebKit::WebMediaPlayer based on URL : [Attachment 152382] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied
wjia at chromium.org's request for review:
Bug 91301: create different WebKit::WebMediaPlayer based on URL
https://bugs.webkit.org/show_bug.cgi?id=91301

Attachment 152382: Patch
https://bugs.webkit.org/attachment.cgi?id=152382&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152382&action=review


> Source/WebKit/chromium/public/WebFrameClient.h:91
> +    virtual WebMediaPlayer* createMediaPlayer(const WebURL&, WebFrame*,
WebMediaPlayerClient*) { return 0; }

nit: WebFrameClient methods always take a WebFrame pointer as their first
parameter.