[webkit-reviews] review denied: [Bug 91143] [BlackBerry] Upstream WebGL Code : [Attachment 152538] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Joshua Netterfield
<jnetterfield at rim.com>'s request for review:
Bug 91143: [BlackBerry] Upstream WebGL Code
https://bugs.webkit.org/show_bug.cgi?id=91143

Attachment 152538: Patch
https://bugs.webkit.org/attachment.cgi?id=152538&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152538&action=review


Still some things to cleanup.

> Source/WebCore/ChangeLog:3
> +	   This patch includes BlackBerry-specific fixes for anti-aliasing,
logging, and shader compilation.

This line should go below the Reviewed by line.

> Source/WebCore/ChangeLog:23
> +	   * platform/graphics/opengl/Extensions3DOpenGL.h: Remove unnecessary 
whitespace.

Remove unnecessary whitespace. <- there is unnecessary whitespace in that
sentence.

> Source/WebKit/ChangeLog:3
> +	   This patch includes BlackBerry-specific fixes for anti-aliasing,
logging, and shader compilation.

This line should go below the Reviewed by line.

> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:142
> +#endif

Better add some whitespace in some of these lines.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:53
> +    // Currently only format=RGBA, type=UNSIGNED_BYTE is supported by the
specification: http://www.khronos.org/reg

Huh? gives 404