[webkit-reviews] review requested: [Bug 81389] Vertical alternate glyph (GSUB) support for OpenTypeVerticalData : [Attachment 152463] Reflected items from Tony's review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 15 20:26:37 PDT 2012


Koji Ishii <kojiishi at gmail.com> has asked  for review:
Bug 81389: Vertical alternate glyph (GSUB) support for OpenTypeVerticalData
https://bugs.webkit.org/show_bug.cgi?id=81389

Attachment 152463: Reflected items from Tony's review
https://bugs.webkit.org/attachment.cgi?id=152463&action=review

------- Additional Comments from Koji Ishii <kojiishi at gmail.com>
* All items in the Tony's review are fixed.
* Overflow in TableBase::validateOffset is unlikely because the offset is
uint16_t, but theoretically possible and fixed as advised.
* Added gtest style unittest at
WebKit/chromium/tests/OpenTypeVerticalDataTest.cpp for testing pointer
validations.


More information about the webkit-reviews mailing list