[webkit-reviews] review requested: [Bug 81389] Vertical alternate glyph (GSUB) support for OpenTypeVerticalData : [Attachment 152462] Reflected items from Tony's review
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 15 10:31:31 PDT 2012
- Previous message: [webkit-reviews] review granted: [Bug 91315] Use testRunner instead of layoutTestController in fast/js, layers, leaks, line-grid, lists, loader, loading, media, mediastream, multicol, and mutation tests : [Attachment 152415] Patch
- Next message: [webkit-reviews] review canceled: [Bug 81389] Vertical alternate glyph (GSUB) support for OpenTypeVerticalData : [Attachment 152462] Reflected items from Tony's review
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Koji Ishii <kojiishi at gmail.com> has asked for review:
Bug 81389: Vertical alternate glyph (GSUB) support for OpenTypeVerticalData
https://bugs.webkit.org/show_bug.cgi?id=81389
Attachment 152462: Reflected items from Tony's review
https://bugs.webkit.org/attachment.cgi?id=152462&action=review
------- Additional Comments from Koji Ishii <kojiishi at gmail.com>
All items in the review are fixed.
Overflow is unlikely because the offset is uint16_t, but theoretically possible
and fixed as advised.
Added gtest style unittest at
WebKit/chromium/tests/OpenTypeVerticalDataTest.cpp for testing pointer
validations.
- Previous message: [webkit-reviews] review granted: [Bug 91315] Use testRunner instead of layoutTestController in fast/js, layers, leaks, line-grid, lists, loader, loading, media, mediastream, multicol, and mutation tests : [Attachment 152415] Patch
- Next message: [webkit-reviews] review canceled: [Bug 81389] Vertical alternate glyph (GSUB) support for OpenTypeVerticalData : [Attachment 152462] Reflected items from Tony's review
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the webkit-reviews
mailing list