[webkit-reviews] review granted: [Bug 91331] Windowless WebView not firing JavaScript load event if there is a media element : [Attachment 152448] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 91331: Windowless WebView not firing JavaScript load event if there is a
media element
https://bugs.webkit.org/show_bug.cgi?id=91331

Attachment 152448: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=152448&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152448&action=review


> Source/WebCore/ChangeLog:12
> +	   In prepareLoad we start deferring the load event. If we fall into
this
> +	   clause where the page can not start loading media we bail,
potentially
> +	   indefinitely waiting until we can start loading media. Since we can
not
> +	   be certain this will ever happen, we should stop deferring the
page's
> +	   load event.

Nit: prepareLoad -> prepareForLoad

> Source/WebCore/ChangeLog:15
> +	   Test: WebKit1.WindowlessWebViewWithMedia TestWebKitAPI test since
that
> +	   is the port and only way that this path was reachable right now.

Nit: "that is the port and only way that ..." is a bit confusing.

> Tools/ChangeLog:10
> +	   Test a windowless WebView loading a page with a media element. The
load
> +	   event should happen on the next spin of the run loop, but we spin
check
> +	   the page, with a timeout of 250ms.

I don't know about WebKit API tests, but a 250ms timeout in a layout test is
short enough that the test would be flakey.