[webkit-reviews] review denied: [Bug 91206] [EFL][WK2] Add ewk_settings. : [Attachment 152413] patch for ewk_settings.

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 91206: [EFL][WK2] Add ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=91206

Attachment 152413: patch for ewk_settings.
https://bugs.webkit.org/attachment.cgi?id=152413&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152413&action=review


Informal r- because of many comments.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:21
> +#ifndef ewk_settings_h

File description is missing.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:577
> +Ewk_Settings* ewk_view_settings_get(Evas_Object* ewkView)

Use *const* keyword for _get() function.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:263
> + * @return the Ewk_Settings of this view

Need to mention what is return on failure.