[webkit-reviews] review canceled: [Bug 91306] Iterating over HTMLCollection backwards is O(n^2) : [Attachment 152400] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 19:49:51 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 91306: Iterating over HTMLCollection backwards is O(n^2)
https://bugs.webkit.org/show_bug.cgi?id=91306

Attachment 152400: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=152400&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152400&action=review


> Source/WebCore/html/HTMLCollection.cpp:245
> +    return onlyIncludeDirectChildren ? previous->previousSibling() :
previous->traverseNextNode(base);

Oops, this won't fly, will it?


More information about the webkit-reviews mailing list