[webkit-reviews] review granted: [Bug 91302] [Mac] Do not try to update the cache model for every WebPreferences change : [Attachment 152398] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 91302: [Mac] Do not try to update the cache model for every WebPreferences
change
https://bugs.webkit.org/show_bug.cgi?id=91302

Attachment 152398: Patch
https://bugs.webkit.org/attachment.cgi?id=152398&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152398&action=review


> Tools/TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:63
> +    // On change, the cache model always take the highest value of any
preference bound to a WebView.

The implementation of _cacheModelChangedNotification will take a higher cache
model even if the WebPreferences object that is changing is not bound to a
WebView. Weird, but that is legacy behavior. You could update this comment.