[webkit-reviews] review denied: [Bug 91299] Paginated views should restrict available height to column height : [Attachment 152376] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Beth Dakin <bdakin at apple.com>'s request for review:
Bug 91299: Paginated views should restrict available height to column height
https://bugs.webkit.org/show_bug.cgi?id=91299

Attachment 152376: Patch
https://bugs.webkit.org/attachment.cgi?id=152376&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=152376&action=review


> Source/WebCore/ChangeLog:9
> +

You should be able to make a layout test for this, using
window.internals.pagination.

> Source/WebCore/rendering/RenderBlock.cpp:5023
> +    if (isRenderView() && hasColumns())
> +	   return columnInfo()->columnHeight();

Why can’t RenderView be the one overriding this function? If we’re not a
RenderView, isRenderView() is going to return false anyway.

> Source/WebCore/rendering/RenderBlock.h:199
> +    virtual LayoutUnit availableLogicalHeight() const;

This override (though I think it will go in RenderView.h) should be annotated
with the OVERRIDE macro.