[webkit-reviews] review granted: [Bug 91162] Move WebCore/platform/text/Base64 to WTF/wtf/text : [Attachment 152347] Add symbols into JavaScriptCore.def

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 91162: Move WebCore/platform/text/Base64 to WTF/wtf/text
https://bugs.webkit.org/show_bug.cgi?id=91162

Attachment 152347: Add symbols into JavaScriptCore.def
https://bugs.webkit.org/attachment.cgi?id=152347&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152347&action=review


> Source/WTF/WTF.xcodeproj/project.pbxproj:771
> +				8134013615B092FD001FF0B8 /* Base64.cpp */,
> +				8134013715B092FD001FF0B8 /* Base64.h */,

You might want to run ./Tools/Scripts/sort-xcodeproj

> Source/WebKit/blackberry/Api/WebKitTextCodec.cpp:105
> +    // Must make sure Base64EncodePolicy is the same in WebKit and WTF!

Maybe add a COMPILE_ASSERT?