[webkit-reviews] review granted: [Bug 90814] Crash in SVGStopElement::stopColorIncludingOpacity : [Attachment 152299] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Stephen Chenney
<schenney at chromium.org>'s request for review:
Bug 90814: Crash in SVGStopElement::stopColorIncludingOpacity
https://bugs.webkit.org/show_bug.cgi?id=90814

Attachment 152299: Patch
https://bugs.webkit.org/attachment.cgi?id=152299&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152299&action=review


Since it is still a hack, you should add a FIXME that this is because of
crashers and needs to be fixed with a bug number. I would still prefer a real
fix. And a test case would be extremely helpful too. Since it is a random
crasher at the moment, I still give r+. Please do the changes on the code
before landing.

> Source/WebCore/svg/SVGStopElement.cpp:116
> +    RenderStyle* styleToUse = renderer() ? renderer()->style() : 0;

IIRC we usually just call it style, not styleToUse.

> Source/WebCore/svg/SVGStopElement.cpp:118
> +	   return Color(0x00000000, true); // Transparent black.

Color(Color::transparent, true) looks better.