[webkit-reviews] review granted: [Bug 90436] Some events should be always stopped at shadow boundary. : [Attachment 150565] stop events at shadow boundary

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 90436: Some events should be always stopped at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=90436

Attachment 150565: stop events at shadow boundary
https://bugs.webkit.org/attachment.cgi?id=150565&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150565&action=review


> Source/WebCore/dom/EventDispatcher.cpp:-367
> -    // WebKit never allowed selectstart event to cross the the shadow DOM
boundary.
> -    // Changing this breaks existing sites.
> -    // See https://bugs.webkit.org/show_bug.cgi?id=52195 for details.

It seems valuable to document this information somewhere. I would just leave it
here if I were you.

> LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary.html:24
> +function debugDispatchedEvent(eventType)

"debug"DispatchedEvent sounds misleading. Maybe dumpDispatchedEvent?