[webkit-reviews] review granted: [Bug 88684] [Chromium] Sometimes bottom of text is truncated when page has a fractional scale : [Attachment 152309] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 88684: [Chromium] Sometimes bottom of text is truncated when page has a
fractional scale
https://bugs.webkit.org/show_bug.cgi?id=88684

Attachment 152309: Patch
https://bugs.webkit.org/attachment.cgi?id=152309&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152309&action=review


Seems reasonable to me and bashi is happy with it.

> Source/WebCore/platform/graphics/skia/SimpleFontDataSkia.cpp:104
> +	       descent++;
> +	       ascent--;

Nit: ++descent and --ascent