[webkit-reviews] review granted: [Bug 91264] EWSTools should be able to build a commit-queue instance from scratch : [Attachment 152300] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 91264: EWSTools should be able to build a commit-queue instance from
scratch
https://bugs.webkit.org/show_bug.cgi?id=91264

Attachment 152300: Patch
https://bugs.webkit.org/attachment.cgi?id=152300&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152300&action=review


LGTM.

> Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh:52
> +gcutil ssh $BOT_ID "sudo apt-get install subversion -y && svn checkout
http://svn.webkit.org/repository/webkit/trunk/Tools/EWSTools tools && cd tools
&& bash configure-svn-auth.sh $SVN_USERNAME $SVN_PASSWORD && bash cold-boot.sh
$QUEUE_TYPE $BOT_ID $BUGZILLA_USERNAME $BUGZILLA_PASSWORD"

I'm sure there is a nicer way to do this.  Even just using \ at the end of the
line to continue to the next, might make sense...