[webkit-reviews] review granted: [Bug 88368] PrettyPatch.rb complains about missing checksum for new pixel results : [Attachment 152287] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 13 10:53:25 PDT 2012
Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 88368: PrettyPatch.rb complains about missing checksum for new pixel
results
https://bugs.webkit.org/show_bug.cgi?id=88368
Attachment 152287: Patch
https://bugs.webkit.org/attachment.cgi?id=152287&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152287&action=review
> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb:74
> + # FIXME: This should match, but there's a bug when running the tests
where the image data
> + # doesn't get properly written out the temp files, so we there there
is no image and don't print
Missing preposition? "...doesn't get properly written out [to] the temp
files..."
Extra 'we there'? "...so /we there/ there is no image..."
> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb:75
> + # the warning that the image is missing it's checksum.
s/it's/its/
More information about the webkit-reviews
mailing list