[webkit-reviews] review denied: [Bug 77936] HTMLMediaElement shouldn't use Element::ensureShadowRoot : [Attachment 152105] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 10:37:17 PDT 2012


Eric Carlson <eric.carlson at apple.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 77936: HTMLMediaElement shouldn't use Element::ensureShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=77936

Attachment 152105: Patch
https://bugs.webkit.org/attachment.cgi?id=152105&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152105&action=review


> Source/WebCore/ChangeLog:38
> +2012-07-11  Shinya Kawanaka	<shinyak at chromium.org>
> +
> +
> +	   When AuthorShadowRoot is being added, this patch adds
UserAgentShadowRoot before adding AuthorShadowRoot.
> +	   So the assumption holds after a user added an AuthorShadowRoot. This
allows user to add a Shadow DOM to
> +	   <video> and <audio>.
> +
> +	   Test: fast/dom/shadow/shadowdom-for-media.html
> +

You forgot to remove this from the ChangeLog.


More information about the webkit-reviews mailing list