[webkit-reviews] review granted: [Bug 90175] [BlackBerry] Implement GCActivityCallback with platform timer : [Attachment 152285] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 13 10:23:16 PDT 2012
Rob Buis <rwlbuis at gmail.com> has granted Yong Li <yoli at rim.com>'s request for
review:
Bug 90175: [BlackBerry] Implement GCActivityCallback with platform timer
https://bugs.webkit.org/show_bug.cgi?id=90175
Attachment 152285: the patch
https://bugs.webkit.org/attachment.cgi?id=152285&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152285&action=review
LGTM.
> Source/JavaScriptCore/heap/HeapTimer.h:70
> + bool m_valid;
May be a bit strange to declare before the getter.
More information about the webkit-reviews
mailing list