[webkit-reviews] review denied: [Bug 91168] REGRESSION: RenderInline boundingBox ignores relative position offset : [Attachment 152127] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 09:06:52 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Kiran Muppala
<cmuppala at apple.com>'s request for review:
Bug 91168: REGRESSION: RenderInline boundingBox ignores relative position
offset
https://bugs.webkit.org/show_bug.cgi?id=91168

Attachment 152127: Patch
https://bugs.webkit.org/attachment.cgi?id=152127&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152127&action=review


> Source/WebCore/rendering/RenderInline.cpp:660
> +	       m_geometryMap.pushMappingsToAncestor(view, 0);
> +	       m_geometryMap.pushMappingsToAncestor(renderer, view);
> +	   }

Does m_geometryMap.pushMappingsToAncestor(renderer, 0); not work? If so, we
should just fix RenderGeometryMap so that it does.


More information about the webkit-reviews mailing list