[webkit-reviews] review requested: [Bug 91234] [Qt] compositing tests need rebaseline with new testfonts : [Attachment 152267] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 13 08:28:25 PDT 2012


Balazs Kelemen <kbalazs at webkit.org> has asked  for review:
Bug 91234: [Qt] compositing tests need rebaseline with new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91234

Attachment 152267: patch
https://bugs.webkit.org/attachment.cgi?id=152267&action=review

------- Additional Comments from Balazs Kelemen <kbalazs at webkit.org>
I'm a bit confused. The tar Ossy created contained expectations in the generic
platform/qt directory that are not exist currently. I checked Ossy's results
with the rebaseline-server and every result was good. However, after I unskip
the tests I still have font differences locally - a few with WebKit2 (13) and
more with WebKit1 (34). Anyway I'm uploading this as I really curios whether I
did what Ossy was planning or I did something wrong. The patch also contains
pixel results because all of them was good too, so snapshot pixels (bug 90394)
should be the same.
Anyway, we should double-check this test (probably on bots) before checking in.


More information about the webkit-reviews mailing list