[webkit-reviews] review granted: [Bug 90949] Optimizing blend filter to ARM-NEON with intrinsics : [Attachment 152235] patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 13 08:07:46 PDT 2012
Zoltan Herczeg <zherczeg at webkit.org> has granted Gabor Rapcsanyi
<rgabor at webkit.org>'s request for review:
Bug 90949: Optimizing blend filter to ARM-NEON with intrinsics
https://bugs.webkit.org/show_bug.cgi?id=90949
Attachment 152235: patch2
https://bugs.webkit.org/attachment.cgi?id=152235&action=review
------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
r=me
View in context: https://bugs.webkit.org/attachment.cgi?id=152235&action=review
> Source/WebCore/ChangeLog:11
> + The feBlend SVG filter modes can be greatly fasten up with ARM-NEON
since
> + we are able to calculate with 2 pixels (8 channels) at the same
time.
> + The code is written with NEON intrinsics and it doesn't affect the
> + general - it has the same behaviour as the original algorithm.
Please mention the speedup.
> Source/WebCore/platform/graphics/filters/FEBlend.cpp:157
> + else { // if there is just one pixel
Please use full sentences for comments.
More information about the webkit-reviews
mailing list